Adaverse commented on code in PR #30950:
URL: https://github.com/apache/airflow/pull/30950#discussion_r1183061403
##########
airflow/www/static/js/dag/details/taskInstance/taskActions/ClearInstance.tsx:
##########
@@ -77,6 +78,10 @@ const ClearInstance = ({
const [failed, setFailed] = useState(false);
const onToggleFailed = () => setFailed(!failed);
+ const initialClearButtonFocusRef = useRef<HTMLButtonElement>(null);
+
+ useKeysPress("shiftKey", ['c', 'C'], onOpen);
Review Comment:
Hi @bbovenzi,
Added below shortcuts to the DAGS grid screen -
- At DagRun
- Clear existing tasks (`shift + c`)
- Mark as success or fail (`shift + s` or `shift + f`)
- Add note (`shift + n`)
- At TaskInstance
- Clear task (`shift + c`)
- Mark as success or fail `(shift + s` or `shift + f`)
- Add note (`shift + n`)
The shortcuts are the same, just depends on what is selected. Will add more
in the process.
Yes, I have checked with major browsers (Chrome, Firefox, Edge, Opera), and
these shortcuts aren't used as of yet (At least nothing happened when I clicked
:)).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
