iantruslove opened a new pull request #5644: [AIRFLOW-5022] Fixes DockerHook for registries with port numbers URL: https://github.com/apache/airflow/pull/5644 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR" - https://issues.apache.org/jira/browse/AIRFLOW-5022 ### Description - [x] Here are some details about my PR: - This fixes a bug where `DockerOperator`s failed authentication when retrieving the image when configured to use a private registry whose URL has a non-standard port number. The root problem was that `DockerHook` ignored the port number of its `conn_id` connection. ### Tests - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: - A small adjustment was made to test_docker_hook.py to cover the fix. ### Commits - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation - [x] In case of new functionality, my PR adds documentation that describes how to use it. - No new functionality in this PR ### Code Quality - [x] Passes `flake8`
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
