ashb commented on code in PR #30713: URL: https://github.com/apache/airflow/pull/30713#discussion_r1184722744
########## airflow/providers/openlineage/extractors/bash.py: ########## @@ -0,0 +1,79 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +import os + +from airflow.providers.openlineage.extractors.base import BaseExtractor, OperatorLineage +from airflow.providers.openlineage.plugins.facets import ( + UnknownOperatorAttributeRunFacet, + UnknownOperatorInstance, +) +from openlineage.client.facet import SourceCodeJobFacet + +""" +:meta private: +""" + + +class BashExtractor(BaseExtractor): + """ + This extractor provides visibility on what bash task does by extracting + executed bash command and putting it into SourceCodeJobFacet. It does not extract + datasets. + + :meta private: + """ + + @classmethod + def get_operator_classnames(cls) -> list[str]: + return ["BashOperator"] + + def extract(self) -> OperatorLineage | None: + collect_source = os.environ.get("OPENLINEAGE_AIRFLOW_DISABLE_SOURCE_CODE", "true").lower() not in ( Review Comment: Should be from airflow conf now? ########## airflow/providers/openlineage/extractors/manager.py: ########## @@ -25,6 +27,26 @@ UnknownOperatorInstance, ) from airflow.utils.log.logging_mixin import LoggingMixin +from airflow.utils.module_loading import import_string + +if TYPE_CHECKING: + from airflow.models import Operator + + +def try_import_from_string(string): + with suppress(ImportError): + return import_string(string) + + +_extractors: list[BaseExtractor] = list( + filter( + lambda t: t is not None, + [ + try_import_from_string("airflow.providers.openlineage.extractors.python.PythonExtractor"), + try_import_from_string("airflow.providers.openlineage.extractors.bash.BashExtractor"), Review Comment: Given these are modules from the same provider I don't see how these could fail? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
