uranusjr commented on code in PR #30706:
URL: https://github.com/apache/airflow/pull/30706#discussion_r1187198663
##########
airflow/jobs/scheduler_job_runner.py:
##########
@@ -1308,9 +1308,19 @@ def _create_dag_runs_dataset_triggered(
DatasetDagRunQueue.target_dag_id == dag_run.dag_id
).delete()
- def _should_update_dag_next_dagruns(self, dag, dag_model: DagModel,
total_active_runs: int) -> bool:
+ def _should_update_dag_next_dagruns(
+ self, dag: DAG, dag_model: DagModel, session: Session,
total_active_runs: int | None = None
+ ) -> bool:
Review Comment:
```suggestion
def _should_update_dag_next_dagruns(
self,
dag: DAG,
dag_model: DagModel,
total_active_runs: int | None = None,
*,
session: Session,
) -> bool:
```
Also adjust the callers to match the signature. Having `session` in the
middle of the arguments is a bit messy to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
