uranusjr commented on code in PR #30706:
URL: https://github.com/apache/airflow/pull/30706#discussion_r1193266580
##########
airflow/timetables/base.py:
##########
@@ -122,11 +122,12 @@ class Timetable(Protocol):
like ``schedule=None`` and ``"@once"`` set it to *False*.
"""
- can_run: bool = True
- """Whether this timetable can actually schedule runs.
+ can_be_scheduled: bool = True
+ """Whether this timetable can actually schedule runs in an automated
manner.
- This defaults to and should generally be *True*, but ``NullTimetable`` sets
- this to *False*.
+ This defaults to and should generally be *True* (including non periodic
+ execution types like *@once* and data triggered tables), but
+ ``NullTimetable`` sets this to *False*.
"""
Review Comment:
We’ll probably need to add some kind of compatibility layer for this, since
`can_run` is technically public interface and may be implemented by an existing
timetable. Something that emits a deprecation warning if `can_run` is
implemented on a timetable but `can_be_scheduled` is not (and forward `can_run`
to `can_be_scheduled`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
