fgalind1 commented on PR #31066: URL: https://github.com/apache/airflow/pull/31066#issuecomment-1539101022
thanks for your review @potiuk > I am a little concerned about the case when the user had `fullnameOverride` set before and performs upgrade with this new chart. Actually `fullnameOverride` is not really used in all resources and only in some. My PR is precisely adding consistency so that all resources honor the same logic > What would happen then? I guess the old resources would remin leaving the k8s deployment with many duplicate resources duplicated - differing by name. > > I think (or maybe I am wrong) that the only way to upgrade in case someone already had fullnameOverride is to delete the old application using old chart and recreate it using the new one. Or delete the whole namespace before reinstalling. > > Or am I wrong? Technically speaking old resources will be deleted by helm if these are renamed, so they will just be replaces with the new resources. The only thing we need to be careful is with the PVCs created by statefulset/deployments, as that means data needs to be moved from the old PVC to the new PVC. To make this change less disruptive, I've added this change as opt-in via an option `useStandardNaming` in values.yaml which is default to False. We may consider setting that to true in the future? At least for new installations users could follow the standard naming conventions This PR bring consistency where by default it won't honor the standard naming convention but optionally and at user's decision they can opt in for standard naming conventions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
