fgalind1 commented on PR #31066:
URL: https://github.com/apache/airflow/pull/31066#issuecomment-1540481295
> This is cool, but I wonder if we can somehow be a more precise od what
needs to be done (or maybe even just say don't do it - delete and recreate your
installation if you want to use standard naming? - this is perfectly fine
IMHO). Also, maybe we can even figure out a way to find out that someone did
not have useStandardNaming set and fail such upgrade?
Makes sense.. added some notes in chart/INSTALL let me know if that could be
a bit more helpful for people that wants to use standard naming conventions
> I got your change (lates) and set "useStandardNaming": true. Nicely we get
better consistency (as expected, and it's cool). With few small things - I
tihnk airflow-postgresgl* and airflow-airflow-config should also be updated to
follow the naming.
**airflow-airflow-config** should be fixed now, config and results-backend,
I've standardized config and results-backend with the rest of the logic, thus I
adjusted tests for those as well, but for those 2 upgrade goes smooth and get
replaced gracefully
**airflow-postgresgl** unfortunately we cannot change anything from postgres
via airflow chart as this is a sub-chart, however we can pass "fullnameOverride
to postgresql to influence the name we want. e.g if we want all resources to be
prefixed with 'airflow-override' then we could do:
```
> helm install airflow chart -n airflow --dry-run --set
useStandardNaming=true,fullnameOverride=airflow-override,postgresql.fullnameOverride=airflow-override-postgresql
| grep -E "^ name: airflow|^kind: State" | tail -n 10
name: airflow-override-statsd
name: airflow-override-webserver
kind: StatefulSet
name: airflow-override-postgresql
kind: StatefulSet
name: airflow-override-redis
kind: StatefulSet
name: airflow-override-triggerer
kind: StatefulSet
name: airflow-override-worker
```
> There are some config errors CreateContainerConfigErrors . I do not have
time to investigate, but I presume it could be connected with the configmap
name wrong?
Should be working on the last commit, indeed it was mismatch on the config
map name. I tried without useStandardNaming, with useStandardNaming and
with/without fullnameOverride and they seem to be working
Thanks again for the feedback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
