utkarsharma2 commented on code in PR #31141:
URL: https://github.com/apache/airflow/pull/31141#discussion_r1188232782
##########
airflow/www/widgets.py:
##########
@@ -40,6 +40,9 @@ class AirflowDateTimePickerWidget:
"</div>"
)
+ def __init__(self, input_required: bool = True):
Review Comment:
@xuganyu96 Thanks for the contribution! :)
I like the idea of making datetime picker optional, but I foresee an issue,
I have not gone through the code, but there can be multiple ways you can
enforce an input field to be required, adding the `required` attribute is one
of them. So I think adding just this code won't guarantee the behavior for all
occurrences. It would be much nicer if we can see in a single PR the change and
its usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
