utkarsharma2 commented on code in PR #31141:
URL: https://github.com/apache/airflow/pull/31141#discussion_r1190718553


##########
airflow/www/widgets.py:
##########
@@ -40,6 +40,9 @@ class AirflowDateTimePickerWidget:
         "</div>"
     )
 
+    def __init__(self, input_required: bool = True):

Review Comment:
   You can enforce the required clause by just JS as well but again I'm not 
entirely sure if there are any scenarios in the airflow codebase where that is 
the case. 
   
   IMO, if you plan to use the optional datetime picker anywhere in the code it 
would give more context if you make those changes in the same PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to