Adaverse commented on code in PR #31165:
URL: https://github.com/apache/airflow/pull/31165#discussion_r1189411892
##########
airflow/www/static/js/dag/details/taskInstance/Logs/index.tsx:
##########
@@ -266,12 +267,14 @@ const Logs = ({
<Text fontSize="sm">{warning}</Text>
</Flex>
)}
- {!!parsedLogs && (
+ {parsedLogs ? (
<LogBlock
parsedLogs={parsedLogs}
wrap={wrap}
tryNumber={taskTryNumber}
/>
+ ) : (
+ <Spinner />
Review Comment:
Changes done. Since `isLoading` is always `false` in the above case because
of the placeholder in the query. Hence, using `isFetching` for the spinner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
