bbovenzi commented on code in PR #31165:
URL: https://github.com/apache/airflow/pull/31165#discussion_r1190153676
##########
airflow/www/static/js/dag/details/taskInstance/Logs/index.tsx:
##########
@@ -266,12 +267,14 @@ const Logs = ({
<Text fontSize="sm">{warning}</Text>
</Flex>
)}
- {!!parsedLogs && (
+ {parsedLogs ? (
<LogBlock
parsedLogs={parsedLogs}
wrap={wrap}
tryNumber={taskTryNumber}
/>
+ ) : (
+ <Spinner />
Review Comment:
Actually, we can get rid of that `placeholderData` and use `isLoading`
normally. `isFetching` can be true when there is still data to show.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
