potiuk commented on PR #31001: URL: https://github.com/apache/airflow/pull/31001#issuecomment-1546659399
> If we go this route, I believe this should be done in another PR, so that this one shouldn't have too much novel code changes and just contain the refactoring. Fair point. > Interesting, I'll have to look into this. As long as it does not slow down the import time through the regular code path this should be fine. This will be only for the "old" ways -> it will not slow down things **too much**. It's basically when .app is imported in the module, the lookup has to be done if there is a dynamic attribute defined, deprecation warning printed, and "real" import returned instead - so. this is mostly the extra lookup + print delay (but it makes sense to get is slower a bit rather than stopping working altogether. Especially that those liveness probes/health checks are also pretty arcane knowledge for users and they sometimes do not realise they exist and just see "restarting worker". Of course it also likely means they won't see the deprecation warning :). but I'd say that is not our worry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
