pierrejeambrun commented on code in PR #31253:
URL: https://github.com/apache/airflow/pull/31253#discussion_r1193024967


##########
clients/gen/python.sh:
##########
@@ -26,7 +26,7 @@ readonly CLEANUP_DIRS
 # shellcheck source=./clients/gen/common.sh
 source "${CLIENTS_GEN_DIR}/common.sh"
 
-VERSION=2.5.1
+VERSION=2.6.0

Review Comment:
   I’m not at home, but I believe that what is missing from the client [release 
process](https://github.com/apache/airflow-client-python/blob/main/dev/README_RELEASE_CLIENT.md)
 is “Update python.sh in airflow/main with the new client version”. Changing 
the version for generating the client is part of the process, (see above) we 
can inspect the generated client, the API version is specified here for 
instance 
https://github.com/apache/airflow-client-python/blob/main/airflow_client/README.md#unknown
 which is correct.
   
   PR to update the client release process is welcome. I think we have the same 
issue with the go client.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to