pankajkoti commented on code in PR #31201:
URL: https://github.com/apache/airflow/pull/31201#discussion_r1193101279
##########
airflow/providers/apache/livy/operators/livy.py:
##########
@@ -207,4 +207,5 @@ def execute_complete(self, context: Context, event:
dict[str, Any]) -> Any:
self.task_id,
event["response"],
)
+ context["ti"].xcom_push(key="app_id",
value=self.get_hook().get_batch(event["batch_id"])["appId"])
Review Comment:
@bdsoha thanks. But do we need it in case of failed tasks too? Or just
successful tasks? Because at the moment the place you have added this in is
only after successful completions.
@potiuk what do you think? Is it an overhead if we push to XCOM backend in
case of failed tasks too? Or it could be fine that we push the XCOM early
irrespective of the task status?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
