potiuk commented on code in PR #31201:
URL: https://github.com/apache/airflow/pull/31201#discussion_r1201962367


##########
airflow/providers/apache/livy/operators/livy.py:
##########
@@ -207,4 +207,5 @@ def execute_complete(self, context: Context, event: 
dict[str, Any]) -> Any:
             self.task_id,
             event["response"],
         )
+        context["ti"].xcom_push(key="app_id", 
value=self.get_hook().get_batch(event["batch_id"])["appId"])

Review Comment:
   I'd be for only pushing on success. This is the "default" behaviour for many 
of our providers and we had discussion about adding an opt-in option to also 
push on failure, but I think generally pushing on success is the default mode 
(and might be the only one until we decide to change the approach globally).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to