potiuk commented on issue #31200: URL: https://github.com/apache/airflow/issues/31200#issuecomment-1546874073
Thanks @thesuperzapper ! This is a fantastic find! Thanks for the analsis - really helpful and absolutely @rcheatham-q and others - no need for the analysis. Indeed, there was a separate case for scheduler job where instead of the 2.1 grace period we overwrote it with the configuration value - and both the configuration value and `is_alive` in SchedulerJobRunner have not been used. I am applying a fix now that will make it into rc3 of 2.6.1 - and it will fix both the `/health` endpoint and `airflow jobs check` command to use the configuration variable for the check. Still I think (just a comment the @thesuperzapper) you should change your Helm Chart to use `airflow jobs check` as of 2.6.1. As of 2.6 we are far more precise on what is and what is not the public interface of Airlfow - and things will break without a warning (even in patchlevel releases) if you base your API interfacing with alrflow on database structure, specific queries, and "random" airflow code executed from outside. While there might be occasional bugs like this one where we missed a case during refactoring, those will be quickly fixed (this one in 2.6.1) and they will remain forward-compatible (`airlfow jobs check` aim is to provide the right check - for example if we get rid of Job table in the future - which might happen without a warning in any release - it will continu to work). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
