thesuperzapper commented on issue #31200: URL: https://github.com/apache/airflow/issues/31200#issuecomment-1548268754
> Still I think (just a comment the @thesuperzapper) you should change your Helm Chart to use `airflow jobs check` as of 2.6.1 - see my comment here: https://github.com/airflow-helm/charts/pull/738#issuecomment-1546851124 . > > As of 2.6 we are far more precise on what is and what is not the [public interface of Airlfow](https://airflow.apache.org/docs/apache-airflow/stable/public-airflow-interface.html) - and things will break without a warning (even in patchlevel releases) if you base your API interfacing with Alrflow: specifically when relying on database structure, specific queries, and "random" airflow code executed from outside. You've been warned. > > While there might be occasional bugs like this one where we missed a case during refactoring, those will be quickly fixed (this one in 2.6.1) and they will remain forward-compatible (`airlfow jobs check` aim is to provide the right check - for example if we get rid of Job table in the future - which might happen without a warning in any release - it will continue to work). > @potiuk the problem is that I'm doing a slightly more complex check than just if there is a `SchedulerJob` running. There is an optional secondary check that ensures tasks are actually being scheduled (in the form of new `LocalTaskJob` appearing), but this check is only started once at least one scheduler has been running for a minimum period (to prevent deadlocks where the probe restarts the scheduler before it gets a chance to schedule something). The reason we need this check is because older versions of airflow will sometimes deadlock and not schedule new tasks but still have a heartbeat, so they look healthy to the normal probe. I'm not sure that this is possible to achieve with the current `airflow jobs check`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
