potiuk commented on code in PR #31277:
URL: https://github.com/apache/airflow/pull/31277#discussion_r1193130891
##########
airflow/jobs/job.py:
##########
@@ -130,10 +130,13 @@ def is_alive(self, grace_multiplier=2.1):
:param grace_multiplier: multiplier of heartrate to require heart beat
within
"""
+ if self.job_type == "SchedulerJob":
+ health_check_threshold: int = conf.getint("scheduler",
"scheduler_health_check_threshold")
Review Comment:
That was the gist of the change in #30302 and #30255 - to get rid of the
Polymorphism we had and keep one "Job" which is not a "BaseJob" any more. We
can (as next step and I **might** do it) move the threshold calculation to
SchedulerJobRunner, but this one is the easiest and safest fix to put specific
exception in the "is_alive" method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
