ashb commented on code in PR #31277:
URL: https://github.com/apache/airflow/pull/31277#discussion_r1193132513
##########
airflow/jobs/job.py:
##########
@@ -130,10 +130,13 @@ def is_alive(self, grace_multiplier=2.1):
:param grace_multiplier: multiplier of heartrate to require heart beat
within
"""
+ if self.job_type == "SchedulerJob":
+ health_check_threshold: int = conf.getint("scheduler",
"scheduler_health_check_threshold")
Review Comment:
This is possibly a change in behaviour.
Previously if you called `SchedulerJob.is_alive(2.2)` it would use the
multiplier instead of the configures threshold.
This is probably okay to ignore the difference but should be called out in a
news fragment?
##########
airflow/jobs/job.py:
##########
@@ -130,10 +130,13 @@ def is_alive(self, grace_multiplier=2.1):
:param grace_multiplier: multiplier of heartrate to require heart beat
within
"""
+ if self.job_type == "SchedulerJob":
+ health_check_threshold: int = conf.getint("scheduler",
"scheduler_health_check_threshold")
Review Comment:
This is tiny a change in behaviour.
Previously if you called `SchedulerJob.is_alive(2.2)` it would use the
multiplier instead of the configures threshold.
This is probably okay to ignore the difference but should be called out in a
news fragment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
