potiuk commented on code in PR #31277:
URL: https://github.com/apache/airflow/pull/31277#discussion_r1193209288
##########
airflow/jobs/job.py:
##########
@@ -130,10 +130,13 @@ def is_alive(self, grace_multiplier=2.1):
:param grace_multiplier: multiplier of heartrate to require heart beat
within
"""
+ if self.job_type == "SchedulerJob":
+ health_check_threshold: int = conf.getint("scheduler",
"scheduler_health_check_threshold")
Review Comment:
cc: @kaxil -> I also added another fixup, where I went a bit further - i.e.
I implemented in the way that SchedulerJobRunner is overriding the threshold,
so that it is not "hard-coded" (so what I discussed above) - I **think** it
might be a bit nicer in the sense it is now not "hard-coded" in Job and moved
to the runner- Job is now not aware about Scheduler Job at all. Maybe that is a
better idea?
(and I removed the grace_multiplier altogether as parameter - converted it
to a constant).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
