potiuk commented on code in PR #31277:
URL: https://github.com/apache/airflow/pull/31277#discussion_r1193210227
##########
airflow/jobs/job.py:
##########
@@ -130,10 +130,13 @@ def is_alive(self, grace_multiplier=2.1):
:param grace_multiplier: multiplier of heartrate to require heart beat
within
"""
+ if self.job_type == "SchedulerJob":
+ health_check_threshold: int = conf.getint("scheduler",
"scheduler_health_check_threshold")
Review Comment:
I move it back - I realized that we cannot do it - > the check **should** be
based on the job_type not set externally by the runner - the way it is used by
`job check` is that it retrives it from the DB - and runner is not involved.
So really the "is_alive" check must apply different threshold based on the
type, not set by the runner.
##########
airflow/jobs/job.py:
##########
@@ -130,10 +130,13 @@ def is_alive(self, grace_multiplier=2.1):
:param grace_multiplier: multiplier of heartrate to require heart beat
within
"""
+ if self.job_type == "SchedulerJob":
+ health_check_threshold: int = conf.getint("scheduler",
"scheduler_health_check_threshold")
Review Comment:
I moved it back - I realized that we cannot do it - > the check **should**
be based on the job_type not set externally by the runner - the way it is used
by `job check` is that it retrives it from the DB - and runner is not involved.
So really the "is_alive" check must apply different threshold based on the
type, not set by the runner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
