pankajkoti commented on code in PR #31279: URL: https://github.com/apache/airflow/pull/31279#discussion_r1193352635
########## airflow/providers/redis/provider.yaml: ########## @@ -39,7 +39,7 @@ dependencies: # as well as unquoting URLS with `urllib.parse.unquote`: # https://github.com/redis/redis-py/blob/master/CHANGES # TODO: upgrade to support redis package >=4 - - redis~=3.2 + - redis~=4.5.5 Review Comment: do we wish to have an upper bound? can we not keep just `>=3.2` I do not have enough context on this. Do we know if there was there a reason that we were not able to support `redis >= 3.3.0` and now we're able to do so? Do we have enough tests in our provider to test the `mixins` and unquoting URLS with `urllib.parse.unquote` as mentioned in the comment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
