potiuk commented on code in PR #31279: URL: https://github.com/apache/airflow/pull/31279#discussion_r1194674905
########## airflow/providers/redis/provider.yaml: ########## @@ -35,11 +35,12 @@ versions: dependencies: - apache-airflow>=2.4.0 - # Redis 4 introduced a number of changes that likely need testing including mixins in redis commands - # as well as unquoting URLS with `urllib.parse.unquote`: - # https://github.com/redis/redis-py/blob/master/CHANGES - # TODO: upgrade to support redis package >=4 - - redis~=3.2 + # Upgrading redis package >= 4 doesn't require code changes + # Changes in Redis 4 only brings into impact when we are directly importing redis.client + # to execute the commands, which we are not doing. + # The issue with unquoting URLS with `urllib.parse.unquote` is also not applicable + # to airflow, because we are not using the from_url function Review Comment: ```suggestion # Upgrading redis package >= 4 doesn't require code changes # Changes in Redis 4 only brings into impact when we are directly importing redis.client # to execute the commands, which we are not doing. # The issue with unquoting URLS with `urllib.parse.unquote` is also not applicable # to airflow, because we are not using the from_url function ``` I think what @eladkal ment (and Also what I think) - you can remove the whole comment now and simply make it part of commit message. There is no point in leaving in the code, but the commit message will carry the trace of this being verified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
