kbumsik commented on code in PR #31276:
URL: https://github.com/apache/airflow/pull/31276#discussion_r1193360359


##########
airflow/providers/amazon/aws/operators/batch.py:
##########
@@ -138,7 +138,7 @@ def __init__(
         waiters: Any | None = None,
         max_retries: int | None = None,
         status_retries: int | None = None,
-        aws_conn_id: str | None = None,
+        aws_conn_id: str | None = 'aws_default',

Review Comment:
   FYI, users still can use an AWS Connection with no credential specified in 
Connection, then the connection uses boto3 credentials.
   
   This is what I am using for AWS Provider. I am using KubernetesExecutor and 
I gave S3 permission to worker pods using k8s service account (AWS IRSA) and I 
make `aws_default` with blank fields. 
   
   So if we decide not allowing None value for `aws_default` then the 
mitigation is easy. This is kinda similar to what happened to KPO #28848 #31187



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to