o-nikolas commented on code in PR #31276:
URL: https://github.com/apache/airflow/pull/31276#discussion_r1194218588
##########
airflow/providers/amazon/aws/operators/batch.py:
##########
@@ -138,7 +138,7 @@ def __init__(
waiters: Any | None = None,
max_retries: int | None = None,
status_retries: int | None = None,
- aws_conn_id: str | None = None,
+ aws_conn_id: str | None = 'aws_default',
Review Comment:
This behaviour is complicated for sure, there are three paths:
1. You provide no value at all for the conn id to the base aws hook: Then
inside the base aws hook the default conn id is used, which will then cause the
standard boto3 creds lookup to be used if the conn is empty or it will use
whatever credentials someone has added to the default aws conn.
1. You provide None as the conn id: in this case the base aws hook will
always use the boto3 lookup no matter what.
1. You provide some specific conn id that you have created with specific
credentials in it which will be used.
So the behaviours of all three are distinctly different and you cannot
simply change it from None to "aws_default" with no effect. HOWEVER, it is a
very small chance this would affect users and there are lots of diverse
perspectives for what is considered a breaking change. You could argue this is
a bug (it's unexpectedly not following the standard of all other aws operators)
and so should be fixed without having to concern ourselves with deprecation
warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
