hussein-awala commented on code in PR #31308:
URL: https://github.com/apache/airflow/pull/31308#discussion_r1194892212
##########
airflow/cli/cli_config.py:
##########
@@ -277,7 +277,12 @@ def string_lower_type(val):
ARG_NO_BACKFILL = Arg(
("--no-backfill",), help="filter all the backfill dagruns given the dag
id", action="store_true"
)
-ARG_STATE = Arg(("--state",), help="Only list the dag runs corresponding to
the state")
+ARG_STATE = Arg(
+ ("--state",),
+ help="Only list the dag runs corresponding to the state",
+ metavar="(table, json, yaml, plain)",
+ choices=("table", "json", "yaml", "plain"),
+)
Review Comment:
IMO it's better to add them dynamically:
```python
>>> from airflow.utils.state import DagRunState
>>> tuple(state.value for state in DagRunState)
('queued', 'running', 'success', 'failed')
>>> str(tuple(state.value for state in DagRunState))
"('queued', 'running', 'success', 'failed')"
```
@uranusjr wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
