[GitHub] [airflow] uranusjr commented on a diff in pull request #31308: Added metavar and choices to --state flag in airflow dags list-jobs CLI for suggesting valid state arguments.

Tue, 16 May 2023 18:50:43 -0700 


uranusjr commented on code in PR #31308:
URL: https://github.com/apache/airflow/pull/31308#discussion_r1195844012


##########
airflow/cli/cli_config.py:
##########
@@ -277,7 +277,12 @@ def string_lower_type(val):
 ARG_NO_BACKFILL = Arg(
     ("--no-backfill",), help="filter all the backfill dagruns given the dag 
id", action="store_true"
 )
-ARG_STATE = Arg(("--state",), help="Only list the dag runs corresponding to 
the state")
+ARG_STATE = Arg(
+    ("--state",),
+    help="Only list the dag runs corresponding to the state",
+    metavar="(running, queued, success, failed)",
+    choices=("running", "queued", "success", "failed"),
+)

Review Comment:
   Instead of `str(dagrun_states)` it’s probably prettier to have `", 
".join(dagrun_states)`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to