jedcunningham commented on code in PR #29926:
URL: https://github.com/apache/airflow/pull/29926#discussion_r1196000965


##########
airflow/config_templates/config.yml:
##########
@@ -1334,6 +1334,13 @@ hive:
 webserver:
   description: ~
   options:
+    config_file:
+      description: |
+        Path of webserver config file used for configuring the webserver 
parameters
+      version_added: 2.6.0

Review Comment:
   This will be 2.7.0 now.
   
   ```suggestion
         version_added: 2.7.0
   ```



##########
airflow/configuration.py:
##########
@@ -1548,9 +1548,8 @@ def initialize_config() -> AirflowConfigParser:
         if local_conf.getboolean("core", "unit_test_mode"):
             local_conf.load_test_config()
 
-    # Make it no longer a proxy variable, just set it to an actual string
     global WEBSERVER_CONFIG

Review Comment:
   Let's move this up to the list of globals at the top of the function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to