jedcunningham commented on code in PR #29926:
URL: https://github.com/apache/airflow/pull/29926#discussion_r1196007187
##########
tests/www/views/test_views.py:
##########
@@ -62,6 +62,22 @@ def test_configuration_expose_config(admin_client):
check_content_in_response(["Airflow Configuration"], resp)
[email protected](os.environ, {"AIRFLOW__WEBSERVER__CONFIG_FILE":
"/tmp/my_custom_webserver_config.py"})
+def test_webserver_configuration_config_file(admin_client):
+ conf = initialize_config()
+ conf.validate()
+
+ assert WEBSERVER_CONFIG == os.path.join(AIRFLOW_HOME,
"webserver_config.py")
Review Comment:
I [pushed a
commit](https://github.com/apache/airflow/pull/29926/commits/41052e3a0ee3bed2350b891f6b594c24deed4c91)
into your branch that fixes the test. Took me a bit of time to get it actually
working, but that exercises the config option and doesn't have any side effects
(like leaving WEBSERVER_CONFIG with the custom config from this test).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
