amoghrajesh commented on code in PR #29929:
URL: https://github.com/apache/airflow/pull/29929#discussion_r1198544689
##########
airflow/executors/kubernetes_executor.py:
##########
@@ -216,15 +233,27 @@ def process_status(
resource_version: str,
event: Any,
) -> None:
+ annotations_string = annotations_to_str(annotations)
"""Process status response."""
if status == "Pending":
if event["type"] == "DELETED":
- self.log.info("Event: Failed to start pod %s", pod_name)
+ if get_logs_task_metadata():
+ self.log.info(
+ "Event: Failed to start pod %s, annotations: %s",
pod_name, annotations_string
+ )
+ else:
+ self.log.info("Event: Failed to start pod %s", pod_name)
Review Comment:
Imo, leaving the omitted annotations would not look good in the logs when we
do not have any annotations or the logs metadata flag enabled. What do you
think? @uranusjr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
