uranusjr commented on code in PR #29929:
URL: https://github.com/apache/airflow/pull/29929#discussion_r1198615556
##########
airflow/kubernetes/kubernetes_helper_functions.py:
##########
@@ -119,3 +120,7 @@ def annotations_to_key(annotations: dict[str, str]) ->
TaskInstanceKey:
try_number=try_number,
map_index=map_index,
)
+
+
+def annotations_to_str(annotations: dict[str, str]) -> str:
+ return json.dumps(annotations)
Review Comment:
Do we really need to go through the JSON serialiser just for logging? Is
simply logging the dict directly problematic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
