pankajkoti commented on code in PR #31201:
URL: https://github.com/apache/airflow/pull/31201#discussion_r1204814904


##########
airflow/providers/apache/livy/operators/livy.py:
##########
@@ -207,4 +207,5 @@ def execute_complete(self, context: Context, event: 
dict[str, Any]) -> Any:
             self.task_id,
             event["response"],
         )
+        context["ti"].xcom_push(key="app_id", 
value=self.get_hook().get_batch(event["batch_id"])["appId"])

Review Comment:
   understood.
   
   wrt. to @bdsoha's comment, they added the XCOM push in their PR 
https://github.com/apache/airflow/pull/27376/files#diff-b8586f3007fabbc894632e59111527536b03a2f576bda13bbcec5df9d3c1338bR144
 after the call to `self.poll_for_termination` method which raises an exception 
if the batch job does not succeed. So, I am guessing they are using the XCOM 
value in downstream tasks only for success scenarios, but, yes, would 
definitely like to hear if they are using/needing it for failure scenarios too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to