pankajkoti commented on code in PR #31567:
URL: https://github.com/apache/airflow/pull/31567#discussion_r1206642829
##########
airflow/providers/amazon/aws/hooks/redshift_sql.py:
##########
@@ -104,7 +104,9 @@ def get_iam_token(self, conn: Connection) -> tuple[str,
str, int]:
port = conn.port or 5439
# Pull the custer-identifier from the beginning of the Redshift URL
# ex. my-cluster.ccdre4hpd39h.us-east-1.redshift.amazonaws.com returns
my-cluster
- cluster_identifier = conn.extra_dejson.get("cluster_identifier",
conn.host.split(".")[0])
+ cluster_identifier = conn.extra_dejson.get("cluster_identifier", None)
+ if conn.host and not cluster_identifier:
Review Comment:
```suggestion
if not cluster_identifier and conn.host:
```
IMO, we could still reverse the conditions here because if the
`cluster_identifier` has been set already in the previous line, we do not need
to process `conn.host` and avoid another check to check if `conn.host` exists
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
