pankajkoti commented on code in PR #31567:
URL: https://github.com/apache/airflow/pull/31567#discussion_r1206716627
##########
airflow/providers/amazon/aws/hooks/redshift_sql.py:
##########
@@ -104,7 +104,9 @@ def get_iam_token(self, conn: Connection) -> tuple[str,
str, int]:
port = conn.port or 5439
# Pull the custer-identifier from the beginning of the Redshift URL
# ex. my-cluster.ccdre4hpd39h.us-east-1.redshift.amazonaws.com returns
my-cluster
- cluster_identifier = conn.extra_dejson.get("cluster_identifier",
conn.host.split(".")[0])
+ cluster_identifier = conn.extra_dejson.get("cluster_identifier", None)
+ if conn.host and not cluster_identifier:
Review Comment:
I believe it should work as a short-circuit operator. The moment it finds a
first `False` condition, it would return as it would not make sense to check
further conditions. In our case, if `cluster_identifier` is already set,
`not cluster_identifier` will evaluate to `False` and it should return
without the need to check for the second condition.
https://python-reference.readthedocs.io/en/latest/docs/operators/and.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
