mik-laj commented on a change in pull request #5664: [AIRFLOW-XXX] fix all 
missing type annotation errors from dmypy
URL: https://github.com/apache/airflow/pull/5664#discussion_r307614002
 
 

 ##########
 File path: airflow/contrib/hooks/gcp_cloud_build_hook.py
 ##########
 @@ -19,8 +19,8 @@
 """Hook for Google Cloud Build service"""
 
 import time
-
-from googleapiclient.discovery import build
+from typing import Optional
+from googleapiclient.discovery import build, Resource
 
 Review comment:
   ```suggestion
   from googleapiclient.discovery import build, Resource
   ```
   I am currently working on annotations for gcp_*_hook.py. 
   https://github.com/apache/airflow/pull/5634
   Can you delete changes from this PR to avoid conflicts? I will be happy if 
you do a review of my changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to