mik-laj commented on a change in pull request #5664: [AIRFLOW-XXX] fix all
missing type annotation errors from dmypy
URL: https://github.com/apache/airflow/pull/5664#discussion_r311287533
##########
File path: airflow/hooks/dbapi_hook.py
##########
@@ -38,7 +38,7 @@ class DbApiHook(BaseHook):
# Override if this db supports autocommit.
supports_autocommit = False
# Override with the object that exposes the connect method
- connector = None
+ connector = None # type: None
Review comment:
Can you enter a protocol here? This variable is not always equal to None, so
entering this annotation will be misleading.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
