XD-DENG commented on code in PR #31559:
URL: https://github.com/apache/airflow/pull/31559#discussion_r1208124909
##########
airflow/models/abstractoperator.py:
##########
@@ -154,37 +154,38 @@ def get_direct_relative_ids(self, upstream: bool = False)
-> set[str]:
return self.upstream_task_ids
return self.downstream_task_ids
- def get_flat_relative_ids(
- self,
- upstream: bool = False,
- found_descendants: set[str] | None = None,
- ) -> set[str]:
- """Get a flat set of relative IDs, upstream or downstream."""
+ def get_flat_relative_ids(self, *, upstream: bool = False) -> set[str]:
+ """
+ Get a flat set of relative IDs, upstream or downstream.
+
+ Will recurse each relative found in the direction specified.
+
+ :param upstream: Whether to look for upstream or downstream relatives.
Review Comment:
Given we are adding the doctoring for it anyway, shall we add the line for
type as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
