tatiana commented on code in PR #31398:
URL: https://github.com/apache/airflow/pull/31398#discussion_r1219668057


##########
airflow/providers/common/sql/hooks/sql.py:
##########
@@ -515,3 +516,40 @@ def test_connection(self):
             message = str(e)
 
         return status, message
+
+    def get_database_info(self, connection):

Review Comment:
   Is this specific to lineage? If yes, would it make sense to mention this in 
the method name explicitly?
   
   It is probably worth adding a docstring.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to