tatiana commented on code in PR #31398:
URL: https://github.com/apache/airflow/pull/31398#discussion_r1219680643
##########
airflow/providers/common/sql/hooks/sql.py:
##########
@@ -515,3 +516,40 @@ def test_connection(self):
message = str(e)
return status, message
+
+ def get_database_info(self, connection):
+ from airflow.providers.openlineage.sqlparser import DatabaseInfo
+
+ return DatabaseInfo(
+ scheme=self.get_database_dialect(connection),
authority=self._get_authority(connection)
+ )
+
+ def get_database_dialect(self, connection):
+ """Method used for SQL parsing. Naively tries to use Connection's
conn_type"""
+ return connection.conn_type
+
+ def _get_authority(self, connection):
+ """Returns authority part (without user info) of OpenLineage namespace
URI."""
Review Comment:
Perhaps the docstring could contain an example and focus on what it returns
(host and port), as opposed to what it doesn't (path)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
