syedahsn commented on code in PR #31712:
URL: https://github.com/apache/airflow/pull/31712#discussion_r1220488809
##########
airflow/providers/amazon/aws/hooks/base_aws.py:
##########
@@ -604,7 +607,7 @@ def get_client_type(
self,
region_name: str | None = None,
config: Config | None = None,
- deferrable: bool = False,
+ deferrable: bool = DEFAULT_DEFERRABLE,
Review Comment:
I don't think setting `deferrable` to `True` will work here, nor is it
necessary. `deferrable` should only be set `True` by getting the `async_conn`
property, which calls the series of methods with `deferrable=True`.
Even in an operator using deferrable mode, we want the ability to create
non-deferrable sessions because we often make synchronous API calls before
going to deferrable mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
