Lee-W commented on code in PR #31712:
URL: https://github.com/apache/airflow/pull/31712#discussion_r1221168022
##########
airflow/providers/microsoft/azure/sensors/wasb.py:
##########
@@ -26,6 +26,13 @@
from airflow.providers.microsoft.azure.triggers.wasb import
WasbBlobSensorTrigger, WasbPrefixSensorTrigger
from airflow.sensors.base import BaseSensorOperator
+try:
+ from airflow.models.abstractoperator import DEFAULT_DEFERRABLE
+except ImportError:
+ from airflow.configuration import conf
+
+ DEFAULT_DEFERRABLE = conf.getboolean("operators", "default_deferrable",
fallback=False)
+
Review Comment:
I am considering moving this logic to the base operator, as suggested by
@uranusjr, in order to eliminate the need for this import. However, I am
uncertain of best approach to address the possible compatibility issues
outlined in
https://github.com/apache/airflow/pull/31712#issuecomment-1580187407. Would
bumping a major version for the providers be a suitable solution?
##########
airflow/providers/microsoft/azure/sensors/wasb.py:
##########
@@ -26,6 +26,13 @@
from airflow.providers.microsoft.azure.triggers.wasb import
WasbBlobSensorTrigger, WasbPrefixSensorTrigger
from airflow.sensors.base import BaseSensorOperator
+try:
+ from airflow.models.abstractoperator import DEFAULT_DEFERRABLE
+except ImportError:
+ from airflow.configuration import conf
+
+ DEFAULT_DEFERRABLE = conf.getboolean("operators", "default_deferrable",
fallback=False)
+
Review Comment:
I am considering moving this logic to the base operator, as suggested by
@uranusjr, in order to eliminate the need for this import. However, I am
uncertain of the best approach to address the possible compatibility issues
outlined in
https://github.com/apache/airflow/pull/31712#issuecomment-1580187407. Would
bumping a major version for the providers be a suitable solution?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
