vincbeck commented on code in PR #31725:
URL: https://github.com/apache/airflow/pull/31725#discussion_r1221982638
##########
airflow/metrics/otel_logger.py:
##########
@@ -83,10 +94,45 @@ def name_is_otel_safe(prefix: str, name: str) -> bool:
return bool(stat_name_otel_handler(prefix, name,
max_length=OTEL_NAME_MAX_LENGTH))
+def _type_as_str(obj: Instrument) -> str:
+ """
+ Given an OpenTelemetry Instrument, returns the type of instrument as a
string.
+
+ type() will return something like: <class
'opentelemetry.sdk.metrics._internal.instrument._Counter'>
+ This extracts that down to just "Counter" (or "Gauge" or whatever) for
cleaner logging purposes.
+
+ :param obj: An OTel Instrument or subclass
+ :returns: The type() of the Instrument without all the nested class info
+ """
+ return str(type(obj)).split(".")[-1][1:-2]
+
+
+def _get_otel_safe_name(name: str) -> str:
+ """
+ OpenTelemetry has a maximum length for metric names. This method returns
the
+ name, truncated if it is too long, and logs a warning so the user will
know.
+
+ :param name: The original metric name
+ :returns: The name, truncated to an OTel-acceptable length if required
+ """
+ otel_safe_name = name[:OTEL_NAME_MAX_LENGTH]
+ if name != otel_safe_name:
+ warnings.warn(
+ f"Metric name `{name}` exceeds OpenTelemetry's name length limit
of "
+ f"{OTEL_NAME_MAX_LENGTH} characters and will be truncated to
`{otel_safe_name}`."
+ )
+ return otel_safe_name
Review Comment:
Super tiny nit: it MIGHT be easier to understand that way
```suggestion
if len(name) > OTEL_NAME_MAX_LENGTH:
warnings.warn(
f"Metric name `{name}` exceeds OpenTelemetry's name length limit
of "
f"{OTEL_NAME_MAX_LENGTH} characters and will be truncated to
`{otel_safe_name}`."
)
return name[:OTEL_NAME_MAX_LENGTH]
```
##########
airflow/metrics/otel_logger.py:
##########
@@ -154,9 +200,20 @@ def gauge(
delta: bool = False,
*,
tags: Attributes = None,
+ back_compat_name: str = "",
) -> None:
- warnings.warn("OpenTelemetry Gauges are not yet implemented.")
- return None
+ if rate < 0:
+ raise ValueError("rate must be a positive value.")
+ if rate < 1 and random.random() > rate:
Review Comment:
Maybe add a comment to explain why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
