ferruzzi commented on code in PR #31725:
URL: https://github.com/apache/airflow/pull/31725#discussion_r1222245210
##########
airflow/metrics/otel_logger.py:
##########
@@ -83,10 +95,45 @@ def name_is_otel_safe(prefix: str, name: str) -> bool:
return bool(stat_name_otel_handler(prefix, name,
max_length=OTEL_NAME_MAX_LENGTH))
+def _type_as_str(obj: Instrument) -> str:
+ """
+ Given an OpenTelemetry Instrument, returns the type of instrument as a
string.
+
+ type() will return something like: <class
'opentelemetry.sdk.metrics._internal.instrument._Counter'>
+ This extracts that down to just "Counter" (or "Gauge" or whatever) for
cleaner logging purposes.
+
+ :param obj: An OTel Instrument or subclass
+ :returns: The type() of the Instrument without all the nested class info
+ """
+ return str(type(obj)).split(".")[-1][1:-2]
Review Comment:
I'll double check that it's the same result, but if it works I'm all for it.
:+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
