Lee-W commented on code in PR #31712:
URL: https://github.com/apache/airflow/pull/31712#discussion_r1222404064
##########
airflow/providers/microsoft/azure/sensors/wasb.py:
##########
@@ -26,6 +26,13 @@
from airflow.providers.microsoft.azure.triggers.wasb import
WasbBlobSensorTrigger, WasbPrefixSensorTrigger
from airflow.sensors.base import BaseSensorOperator
+try:
+ from airflow.models.abstractoperator import DEFAULT_DEFERRABLE
+except ImportError:
+ from airflow.configuration import conf
+
+ DEFAULT_DEFERRABLE = conf.getboolean("operators", "default_deferrable",
fallback=False)
+
Review Comment:
If we implement that in the base operator, this would be a 2.7+ only
feature. I'm thinking of still handling the default value of `deferrable` in
the base operator but keeping the rest of the logic (i.e., import
`DEFAULT_DEFERRABLE` without removing the `deferrable` attribute in provider
operators) for [2.4, 2.7) compatibility. Once we upgrade the providers' min
version to >= 2.7, the providers can get rid of handling the default value of
`deferrable`.
The following is what I'm going to do, and I'll keep them separate commits
so that we can quickly revert some if I misunderstood anything.
1. Add a `TODO` comment to each of the providers
2. Implement the assignment logic in base operators
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
