ferruzzi commented on code in PR #31725:
URL: https://github.com/apache/airflow/pull/31725#discussion_r1224899718
##########
airflow/metrics/otel_logger.py:
##########
@@ -83,10 +95,51 @@ def name_is_otel_safe(prefix: str, name: str) -> bool:
return bool(stat_name_otel_handler(prefix, name,
max_length=OTEL_NAME_MAX_LENGTH))
+def _type_as_str(obj: Instrument) -> str:
+ """
+ Given an OpenTelemetry Instrument, returns the type of the instrument as a
string.
+
+ :param obj: An OTel Instrument or subclass
+ :returns: The type() of the Instrument without all the nested class info
+ """
+ # type() will return something like: <class
'opentelemetry.sdk.metrics._internal.instrument._Counter'>
+ # This extracts that down to just "Counter" (or "Gauge", etc.) for cleaner
logging purposes.
Review Comment:
fixed, thanks. I'd say it's still kind of accurate, just less relevant :P
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
