mobuchowski commented on code in PR #31293:
URL: https://github.com/apache/airflow/pull/31293#discussion_r1228094728
##########
airflow/providers/openlineage/extractors/base.py:
##########
@@ -84,6 +84,12 @@ def get_operator_classnames(cls) -> list[str]:
def extract(self) -> OperatorLineage | None:
try:
return
self._get_openlineage_facets(self.operator.get_openlineage_facets_on_start) #
type: ignore
+ except ImportError:
+ self.log.error(
+ "OpenLineage provider method failed to import OpenLineage
integration. "
Review Comment:
So this is somehow a failsafe that might not make sense - but I think it's
better than having try-except chains in the implementation method itself.
Basically we call OL method that imports OL modules, and call it from OL
integration - so it should never raise exception, in theory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
