mobuchowski commented on code in PR #31293:
URL: https://github.com/apache/airflow/pull/31293#discussion_r1228095760
##########
airflow/providers/google/cloud/operators/bigquery.py:
##########
@@ -1138,7 +1139,7 @@ def execute(self, context: Context):
impersonation_chain=self.impersonation_chain,
)
if isinstance(self.sql, str):
- job_id: str | list[str] = self.hook.run_query(
+ self.job_id = self.hook.run_query(
Review Comment:
Yes. I think it's better to store it as attribute - this means no
unnecessary call to xcom backend, as we're inside the same process when calling
the openlineage method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
