vandonr-amz commented on code in PR #31838:
URL: https://github.com/apache/airflow/pull/31838#discussion_r1228401390
##########
airflow/providers/amazon/aws/operators/ecs.py:
##########
@@ -506,25 +515,24 @@ def execute(self, context, session=None):
@AwsBaseHook.retry(should_retry_eni)
def _start_wait_check_task(self, context):
-
if not self.arn:
self._start_task(context)
+ if not self.wait_for_completion:
+ return
+
Review Comment:
Yeah, idk, we may want to keep the existing behavior, but what I don't like
about it is that it made the operator slower just for the sake of maybe getting
a couple of logs...
Since we were starting the thread, which slept for 30 seconds (or configured
value) before checking if it was stopped, this operator would take 30 seconds
to return no matter what, when the job was done in a second and a half.
It's like "don't wait for completion but still wait a bit"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
