vincbeck commented on code in PR #31838:
URL: https://github.com/apache/airflow/pull/31838#discussion_r1232316815
##########
tests/system/providers/amazon/aws/example_ecs.py:
##########
@@ -85,6 +93,7 @@ def get_region():
asg_name = f"{env_id}-asg"
aws_region = get_region()
+ log_group_name = "/ecs/hello-world"
Review Comment:
I would make this name dynamic (use the env_id as prefix or suffix). Just so
we can run twice the same test in parallel
##########
airflow/providers/amazon/aws/operators/ecs.py:
##########
@@ -506,25 +515,24 @@ def execute(self, context, session=None):
@AwsBaseHook.retry(should_retry_eni)
def _start_wait_check_task(self, context):
-
if not self.arn:
self._start_task(context)
+ if not self.wait_for_completion:
+ return
+
Review Comment:
I'd agree with Raph, I dont think this is a desired behavior but more an
forgotten edge case. I would call it a bug fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
