dwreeves commented on PR #31846: URL: https://github.com/apache/airflow/pull/31846#issuecomment-1589713114
The scope of the PR increased a little bit here. Hope that isn't too bad. - I replaced all `parameters: Iterable | Mapping | None`s with `parameters: Iterable | Mapping[str, Any] | None`s. - I also type-annotated most (but not all-- some I wasn't sure whether they hooked into a SQLAlchemy connection) `parameters` kwargs that were un-annotated that I could find. - I removed two superfluous `run()` methods for `DbApiHook` subclasses. These were just doing `return super().run(...)` with no other changes. I could not find any reason for these methods not just default to the subclassed version. I am aware that provider package version conflicts can sometimes necessitate doing things like this, but that didn't seem to make sense here. (Let me know if I'm missing something.) The last major changes to the `run()` methods occur in this PR: https://github.com/apache/airflow/commit/df00436569bb6fb79ce8c0b7ca71dddf02b854ef and from what I can tell: - The **Trino** hook used to be a lot of custom code that was replaced with `return super().run(...)`. - The **Presto** hook used to have a `super().run()` to warn users about a deprecated kwarg (`hql`) that no longer exists. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
